Merged
Conversation
ThatSpaceGuy
force-pushed
the
LG-10912-Email-Monthly-Report
branch
from
c21abd2 to
32fe8e8
Compare
ThatSpaceGuy
force-pushed
the
LG-10912-Email-Monthly-Report
branch
from
ef0648f to
0298901
Compare
n1zyy
reviewed
Sep 25, 2023
changelog: Internal, formatting, un-embed the CSV from within JSON
changelog: Internal, Reporting, Add Emailed Key Metrics Report
ThatSpaceGuy
force-pushed
the
LG-10912-Email-Monthly-Report
branch
from
0a2eaad to
2722c13
Compare
zachmargolis
approved these changes
Sep 26, 2023
Comment on lines
+12
to
+20
| allow(IdentityConfig.store).to receive(:team_agnes_email).and_return( | ||
| agnes_email, | ||
| ) | ||
| allow(IdentityConfig.store).to receive(:team_all_feds_email).and_return( | ||
| feds_email, | ||
| ) | ||
| allow(Identity::Hostdata).to receive(:env).and_return( | ||
| 'prod', | ||
| ) |
Contributor
There was a problem hiding this comment.
style nit, I prefer to keep these a little more vertically short if possible
Suggested change
| allow(IdentityConfig.store).to receive(:team_agnes_email).and_return( | |
| agnes_email, | |
| ) | |
| allow(IdentityConfig.store).to receive(:team_all_feds_email).and_return( | |
| feds_email, | |
| ) | |
| allow(Identity::Hostdata).to receive(:env).and_return( | |
| 'prod', | |
| ) | |
| allow(IdentityConfig.store).to receive(:team_agnes_email). | |
| and_return(agnes_email) | |
| allow(IdentityConfig.store).to receive(:team_all_feds_email). | |
| and_return(feds_email) | |
| allow(Identity::Hostdata).to receive(:env). | |
| and_return('prod') |
Contributor
Author
There was a problem hiding this comment.
Done - I wonder if we can get the linter to prefer this formatting over the other formatting (which was auto-implemented)? 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://cm-jira.usa.gov/browse/LG-10912
👀 Screenshots
Here is an example of what the Monthly Key Metrics Report looks like:
